From: Ján Tomko <jtomko@redhat.com>
Date: Thu, 18 Feb 2021 13:23:22 +0000 (+0100)
Subject: qemu: monitor: clear cpu props properly in CPUInfoClear
X-Git-Tag: v7.1.0-rc1~52
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=35ce344bfe64fe399b691b42249ae27cf7e5c887;p=thirdparty%2Flibvirt.git

qemu: monitor: clear cpu props properly in CPUInfoClear

Stay true to the name of the function and clear the pointer
after freeing it.

This also silences a bogus Coverity report about a double
free in qemuMonitorGetCPUInfo where qemuMonitorCPUInfoClear
is called right after allocating a new qemuMonitorCPUInfo
to fill out the non-zero defaults.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
---

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 0476d606f5..151f69acef 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -1661,6 +1661,7 @@ qemuMonitorCPUInfoClear(qemuMonitorCPUInfoPtr cpus,
         VIR_FREE(cpus[i].alias);
         VIR_FREE(cpus[i].type);
         virJSONValueFree(cpus[i].props);
+        cpus[i].props = NULL;
     }
 }