From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Sun, 15 Feb 2026 21:34:01 +0000 (+0000)
Subject: libkmod/libkmod-signature: drop pkcs7_private::key_id sign-ness
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=35e8faa2a4f0c24356db589afff8e55ac9c5bdfb;p=thirdparty%2Fkmod.git

libkmod/libkmod-signature: drop pkcs7_private::key_id sign-ness

There is no signed/unsigned declaration in kmod_signature_info, so let's
do the same for the private declaration.

Silence BN_bn2bin(), by applying the cast locally.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/427
Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
---

diff --git a/libkmod/libkmod-signature.c b/libkmod/libkmod-signature.c
index e50c1681..04ef5498 100644
--- a/libkmod/libkmod-signature.c
+++ b/libkmod/libkmod-signature.c
@@ -106,7 +106,7 @@ static bool fill_default(const char *mem, off_t size,
 
 struct pkcs7_private {
 	PKCS7 *pkcs7;
-	unsigned char *key_id;
+	char *key_id;
 	BIGNUM *sno;
 	char *hash_algo;
 };
@@ -166,7 +166,7 @@ static bool fill_pkcs7(const char *mem, off_t size, size_t sig_len,
 	const ASN1_OBJECT *o;
 	BIO *in;
 	int len;
-	unsigned char *key_id_str;
+	char *key_id_str;
 	struct pkcs7_private *pvt;
 	const char *issuer_str;
 	char *hash_algo;
@@ -216,9 +216,9 @@ static bool fill_pkcs7(const char *mem, off_t size, size_t sig_len,
 	key_id_str = malloc(len);
 	if (key_id_str == NULL)
 		goto err2;
-	BN_bn2bin(sno_bn, key_id_str);
+	BN_bn2bin(sno_bn, (unsigned char *)key_id_str);
 
-	sig_info->key_id = (const char *)key_id_str;
+	sig_info->key_id = key_id_str;
 	sig_info->key_id_len = len;
 
 	issuer_str = x509_name_to_str(issuer);