From: Daniel Stenberg <daniel@haxx.se>
Date: Fri, 10 Nov 2017 13:59:19 +0000 (+0100)
Subject: curl_share_setopt: va_end was not called if conncache errors
X-Git-Tag: curl-7_57_0~43
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3619ee5febb220de917db642352f9ea4fc3e7843;p=thirdparty%2Fcurl.git

curl_share_setopt: va_end was not called if conncache errors

CID 984459, detected by Coverity
---

diff --git a/lib/share.c b/lib/share.c
index c1ce1aab11..870b191fc2 100644
--- a/lib/share.c
+++ b/lib/share.c
@@ -103,7 +103,7 @@ curl_share_setopt(struct Curl_share *share, CURLSHoption option, ...)
 
     case CURL_LOCK_DATA_CONNECT:     /* not supported (yet) */
       if(Curl_conncache_init(&share->conn_cache, 103))
-        return CURLSHE_NOMEM;
+        res = CURLSHE_NOMEM;
       break;
 
     default: