From: Michal Rakowski <michal.rakowski@baculasystems.com>
Date: Mon, 18 Oct 2021 20:04:32 +0000 (+0200)
Subject: remove redundant restore_cleanup()
X-Git-Tag: Beta-15.0.0~806
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=363e5f7252a0d25cf5dbdb3c7af9c87f71501f0a;p=thirdparty%2Fbacula.git

remove redundant restore_cleanup()

For the success path, it's called anyway, for the error path it's called
if the `do_restore()` fails, so there is no need to call it twice.
---

diff --git a/bacula/src/dird/restore.c b/bacula/src/dird/restore.c
index 89e09e350..73b8c1f2b 100644
--- a/bacula/src/dird/restore.c
+++ b/bacula/src/dird/restore.c
@@ -597,7 +597,6 @@ bool do_restore(JCR *jcr)
    return true;
 
 bail_out:
-   restore_cleanup(jcr, JS_ErrorTerminated);
    return false;
 }