From: Evan Hunt <each@isc.org>
Date: Sat, 6 Jun 2020 01:55:22 +0000 (-0700)
Subject: ensure clientstr is null-terminated
X-Git-Tag: v9.17.2~8^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=364b349ad2905d3d907ccb3af1339a8528c16653;p=thirdparty%2Fbind9.git

ensure clientstr is null-terminated
---

diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c
index a6d0a65eabe..5a1f0c9f06a 100644
--- a/lib/dns/resolver.c
+++ b/lib/dns/resolver.c
@@ -4996,7 +4996,7 @@ fctx_create(dns_resolver_t *res, const dns_name_t *name, dns_rdatatype_t type,
 		isc_sockaddr_format(client, fctx->clientstr,
 				    sizeof(fctx->clientstr));
 	} else {
-		memmove(fctx->clientstr, "<unknown>", sizeof("<unknown"));
+		strlcpy(fctx->clientstr, "<unknown>", sizeof(fctx->clientstr));
 	}
 	fctx->ns_ttl = 0;
 	fctx->ns_ttl_ok = false;