From: Jelte Jansen <jelte@isc.org>
Date: Wed, 12 Dec 2012 22:25:29 +0000 (+0100)
Subject: [2541] Update in-code comment
X-Git-Tag: bind10-1.0.0-beta-release~26^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3666cb4d97d21903f1637796edab95bb466c213e;p=thirdparty%2Fkea.git

[2541] Update in-code comment
---

diff --git a/src/lib/datasrc/database.cc b/src/lib/datasrc/database.cc
index 62da2e0d44..b65bc08f43 100644
--- a/src/lib/datasrc/database.cc
+++ b/src/lib/datasrc/database.cc
@@ -1397,11 +1397,8 @@ public:
                 logger.info(DATASRC_DATABASE_UPDATER_ROLLBACK)
                     .arg(zone_name_).arg(zone_class_).arg(db_name_);
             } catch (const DataSourceError& e) {
-                // We generally expect that rollback always succeeds, and
-                // it should in fact succeed in a way we execute it.  But
-                // as the public API allows rollback() to fail and
-                // throw, we should expect it.  Obviously we cannot re-throw
-                // it.  The best we can do is to log it as a critical error.
+                // See The destructor ~TransactionHolder() for the
+                // reason to catch this.
                 logger.error(DATASRC_DATABASE_UPDATER_ROLLBACKFAIL)
                     .arg(zone_name_).arg(zone_class_).arg(db_name_)
                     .arg(e.what());