From: GeoSot Date: Thu, 10 Mar 2022 00:07:01 +0000 (+0200) Subject: Carousel: rename private property X-Git-Tag: v5.2.0-beta1~156 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3673933fe74b4323267b0b0a7871a393ce2ff5cb;p=thirdparty%2Fbootstrap.git Carousel: rename private property --- diff --git a/js/src/carousel.js b/js/src/carousel.js index edaec08f2d..5a9b2dc846 100644 --- a/js/src/carousel.js +++ b/js/src/carousel.js @@ -97,7 +97,7 @@ class Carousel extends BaseComponent { this._interval = null this._activeElement = null - this._isPaused = false + this._stayPaused = false this._isSliding = false this.touchTimeout = null this._swipeHelper = null @@ -139,7 +139,7 @@ class Carousel extends BaseComponent { pause(event) { if (!event) { - this._isPaused = true + this._stayPaused = true } if (SelectorEngine.findOne(SELECTOR_NEXT_PREV, this._element)) { @@ -152,11 +152,11 @@ class Carousel extends BaseComponent { cycle(event) { if (!event) { - this._isPaused = false + this._stayPaused = false } this._clearInterval() - if (this._config.interval && !this._isPaused) { + if (this._config.interval && !this._stayPaused) { this._updateInterval() this._interval = setInterval(() => this.nextWhenVisible(), this._config.interval) diff --git a/js/tests/unit/carousel.spec.js b/js/tests/unit/carousel.spec.js index 536a60e271..9817b83f1c 100644 --- a/js/tests/unit/carousel.spec.js +++ b/js/tests/unit/carousel.spec.js @@ -891,7 +891,7 @@ describe('Carousel', () => { expect(carousel.cycle).toHaveBeenCalledWith(true) expect(carousel._clearInterval).toHaveBeenCalled() - expect(carousel._isPaused).toBeTrue() + expect(carousel._stayPaused).toBeTrue() }) it('should not call cycle if nothing is in transition', () => { @@ -917,7 +917,7 @@ describe('Carousel', () => { expect(carousel.cycle).not.toHaveBeenCalled() expect(carousel._clearInterval).toHaveBeenCalled() - expect(carousel._isPaused).toBeTrue() + expect(carousel._stayPaused).toBeTrue() }) it('should not set is paused at true if an event is passed', () => { @@ -942,7 +942,7 @@ describe('Carousel', () => { carousel.pause(event) expect(carousel._clearInterval).toHaveBeenCalled() - expect(carousel._isPaused).toBeFalse() + expect(carousel._stayPaused).toBeFalse() }) }) @@ -988,7 +988,7 @@ describe('Carousel', () => { spyOn(window, 'setInterval').and.callThrough() - carousel._isPaused = true + carousel._stayPaused = true carousel.cycle(true) expect(window.setInterval).not.toHaveBeenCalled()