From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 2 Nov 2010 21:31:54 +0000 (-0400)
Subject: Fix buffer overrun in pg_upgrade.
X-Git-Tag: REL9_0_2~39
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=368e44f6a54a81d036fb85ea0f4544a233d7cf11;p=thirdparty%2Fpostgresql.git

Fix buffer overrun in pg_upgrade.

Problem reported, and cause identified, by Hernan Gonzalez.
---

diff --git a/contrib/pg_upgrade/controldata.c b/contrib/pg_upgrade/controldata.c
index 009a1cc0985..dd805a42acd 100644
--- a/contrib/pg_upgrade/controldata.c
+++ b/contrib/pg_upgrade/controldata.c
@@ -545,7 +545,7 @@ putenv2(migratorContext *ctx, const char *var, const char *val)
 	{
 #ifndef WIN32
 		char	   *envstr = (char *) pg_malloc(ctx, strlen(var) +
-												strlen(val) + 1);
+												strlen(val) + 2);
 
 		sprintf(envstr, "%s=%s", var, val);
 		putenv(envstr);