From: Petr Špaček <petr.spacek@nic.cz>
Date: Fri, 24 Nov 2017 13:55:35 +0000 (+0100)
Subject: CI: disable Deckard under Valgrind
X-Git-Tag: v1.5.1~14^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3696776ffc4b8fdb0eef69ea9795c7e3742cc305;p=thirdparty%2Fknot-resolver.git

CI: disable Deckard under Valgrind

The test is useless in its current form because all the information goes
to logs, which are later discarded.

We need to fix issues detected by Valgrind first and then enable strict
mode which will not let the test pass if any problem is detected.

This might require recompiling LuaJIT in a way which is compatible with
Valgrind.
---

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 9e36b278e..8cf5d40e0 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -49,25 +49,26 @@ deckard:linux:amd64:
     - amd64
 
 
-deckard:linux:amd64:valgrind:
-  stage: test
-  script:
-    - export PREFIX=$(pwd)/.local
-    - export LD_LIBRARY_PATH=$PREFIX/lib
-    - export TMPDIR=$(pwd)
-    # TODO: valgrind missing parameter --error-exitcode=1 to fail make on error
-    - cd tests/deckard && DAEMON=valgrind ADDITIONAL="--leak-check=full --trace-children=yes --quiet --suppressions=/lj.supp $PREFIX/sbin/kresd -f 1" MAKEFLAGS="-j $(nproc) --keep-going" make
-  artifacts:
-    when: on_failure
-    expire_in: 1 week
-    paths:
-      - tmpdeckard*
-  dependencies:
-    - build:linux:amd64
-  tags:
-    - docker
-    - linux
-    - amd64
+# temporarily disabled - we need to fix issues first
+#deckard:linux:amd64:valgrind:
+#  stage: test
+#  script:
+#    - export PREFIX=$(pwd)/.local
+#    - export LD_LIBRARY_PATH=$PREFIX/lib
+#    - export TMPDIR=$(pwd)
+#    # TODO: valgrind missing parameter --error-exitcode=1 to fail make on error
+#    - cd tests/deckard && DAEMON=valgrind ADDITIONAL="--leak-check=full --trace-children=yes --quiet --suppressions=/lj.supp $PREFIX/sbin/kresd -f 1" MAKEFLAGS="-j $(nproc) --keep-going" make
+#  artifacts:
+#    when: on_failure
+#    expire_in: 1 week
+#    paths:
+#      - tmpdeckard*
+#  dependencies:
+#    - build:linux:amd64
+#  tags:
+#    - docker
+#    - linux
+#    - amd64
 
 
 test:linux:amd64:valgrind: