From: Markus Stockhausen Date: Sun, 3 May 2026 16:53:37 +0000 (+0200) Subject: realtek: mdio: harden RTMDIO_C45_DATA macro X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=36abcb5fceb2ca0ea8733520242a8af0c85d850f;p=thirdparty%2Fopenwrt.git realtek: mdio: harden RTMDIO_C45_DATA macro Maximum devnum in c45 access is only 31. The bits 21-31 of the MMD register are reserved and cannot be written. Nevertheless add a proper mask to help AI review bots. Signed-off-by: Markus Stockhausen Link: https://github.com/openwrt/openwrt/pull/23204 Signed-off-by: Robert Marko --- diff --git a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c index 57ff941b770..329bafcc961 100644 --- a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c +++ b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c @@ -44,7 +44,8 @@ ((reg) & GENMASK(15, 0))) /* MDIO bus registers/fields */ -#define RTMDIO_C45_DATA(devnum, regnum) (((devnum) << 16) | ((regnum) & GENMASK(15, 0))) +#define RTMDIO_C45_DATA(devnum, regnum) ((((devnum) & GENMASK(4, 0)) << 16) | \ + ((regnum) & GENMASK(15, 0))) #define RTMDIO_DATA_MASK GENMASK(15, 0) #define RTMDIO_RUN BIT(0)