From: Volker Lendecke <vl@samba.org>
Date: Thu, 29 Sep 2022 09:00:41 +0000 (+0200)
Subject: smbXcli: Align smb2cli_req_create() with tevent_req conventions
X-Git-Tag: talloc-2.4.0~788
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=36bd73e836f733068bdc9bb5df704f825fac7d2e;p=thirdparty%2Fsamba.git

smbXcli: Align smb2cli_req_create() with tevent_req conventions

We don't return NULL if tevent_req_create() succeeded, and elsewhere
in this function we already pass tevent_req_nterror or
tevent_req_nomem (via set_endtime).

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index 47f385349c4..29ece6a271a 100644
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -3081,9 +3081,8 @@ struct tevent_req *smb2cli_req_create(TALLOC_CTX *mem_ctx,
 	}
 
 	state->smb2.recv_iov = talloc_zero_array(state, struct iovec, 3);
-	if (state->smb2.recv_iov == NULL) {
-		TALLOC_FREE(req);
-		return NULL;
+	if (tevent_req_nomem(state->smb2.recv_iov, req)) {
+		return req;
 	}
 
 	flags |= additional_flags;