From: Charles Keepax Date: Tue, 5 May 2026 09:08:11 +0000 (+0100) Subject: ASoC: SDCA: Fix bad move of jack_state initialisation X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=36c543cc51008fbc9ebfaf1e58c34425b7997c88;p=thirdparty%2Flinux.git ASoC: SDCA: Fix bad move of jack_state initialisation The initialisation of jack_state was accidentally moved until after its use, correct this. Fixes: cb3c257e0824 ("ASoC: SDCA: Add correct masks whilst reporting SDCA jack status") Signed-off-by: Charles Keepax Link: https://patch.msgid.link/20260505090811.3697153-1-ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/sdca/sdca_jack.c b/sound/soc/sdca/sdca_jack.c index a2d95b124b789..ae9636622a840 100644 --- a/sound/soc/sdca/sdca_jack.c +++ b/sound/soc/sdca/sdca_jack.c @@ -203,6 +203,8 @@ int sdca_jack_set_jack(struct sdca_interrupt_info *info, struct snd_soc_jack *ja if (!range) return -EINVAL; + jack_state = interrupt->priv; + for (j = 0; j < range->rows; j++) { enum sdca_terminal_type type; @@ -211,7 +213,6 @@ int sdca_jack_set_jack(struct sdca_interrupt_info *info, struct snd_soc_jack *ja jack_state->mask |= type_get_mask(type); } - jack_state = interrupt->priv; jack_state->jack = jack; /* Report initial state in case IRQ was already handled */