From: Kenny Glowner <sisyphuscode0311@gmail.com>
Date: Thu, 21 May 2026 16:14:05 +0000 (-0500)
Subject: rust: module_param: add missing newline to pr_warn_once
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=36d6b929bb0c7cc1cc742d9b5805537d3b651094;p=thirdparty%2Fkernel%2Flinux.git

rust: module_param: add missing newline to pr_warn_once

Add a trailing newline ('\n') to the pr_warn_once! call in set_param to
ensure the kernel ring buffer flushes the message correctly and
prevents log line smearing.

Signed-off-by: Kenny Glowner <SisyphusCode0311@gmail.com>
Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1139
[Sami: Updated the commit message as we use pr_warn_once now.]
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
---

diff --git a/rust/kernel/module_param.rs b/rust/kernel/module_param.rs
index dd6d663a0a3c4..6541af218390c 100644
--- a/rust/kernel/module_param.rs
+++ b/rust/kernel/module_param.rs
@@ -62,7 +62,7 @@ where
     // NOTE: If we start supporting arguments without values, val _is_ allowed
     // to be null here.
     if val.is_null() {
-        crate::pr_warn_once!("Null pointer passed to `module_param::set_param`");
+        crate::pr_warn_once!("Null pointer passed to `module_param::set_param`\n");
         return EINVAL.to_errno();
     }