From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 10 May 2025 04:01:14 +0000 (-0700)
Subject: maint: minor followon touchup of GCC warnings
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=36e83a6bcd055456fc366bbd71199ad786083521;p=thirdparty%2Fcoreutils.git

maint: minor followon touchup of GCC warnings

* configure.ac (GNULIB_TEST_WARN_CFLAGS):
Do not use -Wsuggest-attribute=cold, -Wsuggest-attribute=const,
-Wsuggest-attribute=format as they produce false positives with
GCC 15 x86-64.  Use -Wmissing-variable-declarations, as it no
longer seems to hurt.
---

diff --git a/configure.ac b/configure.ac
index 9c8721f885..54af30535d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -242,7 +242,9 @@ if test $gl_gcc_warnings != no; then
   # For gnulib-tests, the set is slightly smaller still.
   nw=
   # It's not worth being this picky about test programs.
-  nw="$nw -Wmissing-variable-declarations"
+  nw="$nw -Wsuggest-attribute=cold"
+  nw="$nw -Wsuggest-attribute=const"
+  nw="$nw -Wsuggest-attribute=format"
   nw="$nw -Wsuggest-attribute=pure"
   gl_MANYWARN_COMPLEMENT([GNULIB_TEST_WARN_CFLAGS],
                          [$GNULIB_WARN_CFLAGS], [$nw])