From: Matthijs Mekking <matthijs@isc.org>
Date: Wed, 25 Nov 2020 08:23:57 +0000 (+0100)
Subject: load_pubkey_from_engine() should load public key
X-Git-Tag: v9.17.10~21^2~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=370285a62dd1fb5e29972c4160332c729ba67aeb;p=thirdparty%2Fbind9.git

load_pubkey_from_engine() should load public key

The 'function load_pubkey_from_engine()' made a call to the libssl
function 'ENGINE_load_private_key'.  This is a copy paste error and
should be 'ENGINE_load_public_key'.
---

diff --git a/lib/dns/opensslecdsa_link.c b/lib/dns/opensslecdsa_link.c
index dd3c1bbf665..98c41a79389 100644
--- a/lib/dns/opensslecdsa_link.c
+++ b/lib/dns/opensslecdsa_link.c
@@ -628,7 +628,7 @@ load_pubkey_from_engine(EC_KEY *eckey, const char *engine, const char *label) {
 		return (DST_R_NOENGINE);
 	}
 
-	EVP_PKEY *pubkey = ENGINE_load_private_key(ep, label, NULL, NULL);
+	EVP_PKEY *pubkey = ENGINE_load_public_key(ep, label, NULL, NULL);
 	if (pubkey == NULL) {
 		return (dst__openssl_toresult2("ENGINE_load_public_key",
 					       ISC_R_NOTFOUND));