From: Christopher Faulet Date: Fri, 29 Jan 2021 10:30:37 +0000 (+0100) Subject: MINOR: ssl-sample: Don't check if argument list is set in sample fetches X-Git-Tag: v2.4-dev7~47 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3702f78cf9f9db17b13ad637c25bd59370c3fadc;p=thirdparty%2Fhaproxy.git MINOR: ssl-sample: Don't check if argument list is set in sample fetches The list is always defined by definition. Thus there is no reason to test it. --- diff --git a/src/ssl_sample.c b/src/ssl_sample.c index 10c40a904b..e2479f5013 100644 --- a/src/ssl_sample.c +++ b/src/ssl_sample.c @@ -400,7 +400,7 @@ smp_fetch_ssl_x_i_dn(const struct arg *args, struct sample *smp, const char *kw, goto out; smp_trash = get_trash_chunk(); - if (args && args[0].type == ARGT_STR && args[0].data.str.data > 0) { + if (args[0].type == ARGT_STR && args[0].data.str.data > 0) { int pos = 1; if (args[1].type == ARGT_SINT) @@ -409,7 +409,7 @@ smp_fetch_ssl_x_i_dn(const struct arg *args, struct sample *smp, const char *kw, if (ssl_sock_get_dn_entry(name, &args[0].data.str, pos, smp_trash) <= 0) goto out; } - else if (args && args[2].type == ARGT_STR && args[2].data.str.data > 0) { + else if (args[2].type == ARGT_STR && args[2].data.str.data > 0) { if (ssl_sock_get_dn_formatted(name, &args[2].data.str, smp_trash) <= 0) goto out; } @@ -520,7 +520,7 @@ smp_fetch_ssl_x_s_dn(const struct arg *args, struct sample *smp, const char *kw, goto out; smp_trash = get_trash_chunk(); - if (args && args[0].type == ARGT_STR && args[0].data.str.data > 0) { + if (args[0].type == ARGT_STR && args[0].data.str.data > 0) { int pos = 1; if (args[1].type == ARGT_SINT) @@ -529,7 +529,7 @@ smp_fetch_ssl_x_s_dn(const struct arg *args, struct sample *smp, const char *kw, if (ssl_sock_get_dn_entry(name, &args[0].data.str, pos, smp_trash) <= 0) goto out; } - else if (args && args[2].type == ARGT_STR && args[2].data.str.data > 0) { + else if (args[2].type == ARGT_STR && args[2].data.str.data > 0) { if (ssl_sock_get_dn_formatted(name, &args[2].data.str, smp_trash) <= 0) goto out; }