From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Sun, 5 Feb 2023 18:51:12 +0000 (+0200)
Subject: sdbox: Fix panic due to leaked mail_index_view if sync fails
X-Git-Tag: 2.4.0~2949
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=37142afbdb22862d0ebba91749f6169aac28ae53;p=thirdparty%2Fdovecot%2Fcore.git

sdbox: Fix panic due to leaked mail_index_view if sync fails

Fixes:
Panic: Leaked view for index .../dbox-Mails/dovecot.index: Opened in mail-index-sync.c:445
---

diff --git a/src/lib-storage/index/dbox-single/sdbox-sync.c b/src/lib-storage/index/dbox-single/sdbox-sync.c
index c8a0b549a9..1e8879ecf7 100644
--- a/src/lib-storage/index/dbox-single/sdbox-sync.c
+++ b/src/lib-storage/index/dbox-single/sdbox-sync.c
@@ -279,8 +279,8 @@ int sdbox_sync_finish(struct sdbox_sync_context **_ctx, bool success)
 			ret = -1;
 		} else {
 			dbox_sync_expunge_files(ctx);
-			mail_index_view_close(&ctx->sync_view);
 		}
+		mail_index_view_close(&ctx->sync_view);
 	} else {
 		mail_index_sync_rollback(&ctx->index_sync_ctx);
 	}