From: Richard Purdie <richard.purdie@linuxfoundation.org>
Date: Tue, 10 Nov 2015 09:56:51 +0000 (+0000)
Subject: fetch2: Remove crazy code in unpack
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=37214ea9bf484998b75dbc1200d53f1afc5257ed;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

fetch2: Remove crazy code in unpack

This looks reasonable until you realise self.localpath is a function. Data
expansion of something which isn't a string is the original value so this
code just wastes CPU cycles and makes no sense. Remove it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
index 288a1c8fd02..d66a212cb3b 100644
--- a/lib/bb/fetch2/__init__.py
+++ b/lib/bb/fetch2/__init__.py
@@ -1686,9 +1686,6 @@ class Fetch(object):
             ud = self.ud[u]
             ud.setup_localpath(self.d)
 
-            if self.d.expand(self.localpath) is None:
-                continue
-
             if ud.lockfile:
                 lf = bb.utils.lockfile(ud.lockfile)