From: Richard Guenther <rguenther@suse.de>
Date: Mon, 9 Aug 2010 13:18:08 +0000 (+0000)
Subject: re PR tree-optimization/44632 (wrong code for complex division)
X-Git-Tag: releases/gcc-4.6.0~5159
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=37609bf08645fad9c5ea1cd8e06195c6d0fd2c7d;p=thirdparty%2Fgcc.git

re PR tree-optimization/44632 (wrong code for complex division)

2010-08-09  Richard Guenther  <rguenther@suse.de>

	PR middle-end/44632
	* function.c (gimplify_parameters): Do not clear addressable
	bit of the original parameter.

	* g++.dg/opt/nrv17.C: New testcase.

From-SVN: r163031
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index ace409d7e7b2..eea2550d4a77 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2010-08-09  Richard Guenther  <rguenther@suse.de>
+
+	PR middle-end/44632
+	* function.c (gimplify_parameters): Do not clear addressable
+	bit of the original parameter.
+
 2010-08-09  Richard Guenther  <rguenther@suse.de>
 
 	PR middle-end/45212
diff --git a/gcc/function.c b/gcc/function.c
index e89a5c9b78d1..a540d059a86d 100644
--- a/gcc/function.c
+++ b/gcc/function.c
@@ -3570,12 +3570,10 @@ gimplify_parameters (void)
 		  DECL_IGNORED_P (local) = 0;
 		  /* If PARM was addressable, move that flag over
 		     to the local copy, as its address will be taken,
-		     not the PARMs.  */
+		     not the PARMs.  Keep the parms address taken
+		     as we'll query that flag during gimplification.  */
 		  if (TREE_ADDRESSABLE (parm))
-		    {
-		      TREE_ADDRESSABLE (parm) = 0;
-		      TREE_ADDRESSABLE (local) = 1;
-		    }
+		    TREE_ADDRESSABLE (local) = 1;
 		}
 	      else
 		{
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 4455729fe4a8..93ed62f12c0e 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2010-08-09  Richard Guenther  <rguenther@suse.de>
+
+	PR middle-end/44632
+	* g++.dg/opt/nrv17.C: New testcase.
+
 2010-08-09  Richard Guenther  <rguenther@suse.de>
 
 	PR middle-end/45212
diff --git a/gcc/testsuite/g++.dg/opt/nrv17.C b/gcc/testsuite/g++.dg/opt/nrv17.C
new file mode 100644
index 000000000000..6248bca037af
--- /dev/null
+++ b/gcc/testsuite/g++.dg/opt/nrv17.C
@@ -0,0 +1,32 @@
+// { dg-do run }
+
+#include <cstdlib>
+#include <complex>
+
+void __attribute__((noinline))
+h(std::complex<double> x)
+{
+  if (x.real() != 2.0)
+    std::abort ();
+}
+
+void __attribute__((noinline))
+g(std::complex<double> x)
+{
+  if (x.real() != 0.5)
+    std::abort ();
+}
+
+void __attribute__((noinline))
+f(std::complex<double> x)
+{
+  h (x);
+  x = 1.0 / x;
+  g (x);
+}
+
+int main()
+{
+  f(2.0);
+  return 0;
+}