From: Yuriy M. Kaminskiy <yumkam@gmail.com>
Date: Wed, 30 Mar 2016 14:23:53 +0000 (+1300)
Subject: pinger: Fix buffer overflow in Icmp6::Recv
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=376344a2066ba3ce4f35e497a0a7ed69099cbf2c;p=thirdparty%2Fsquid.git

pinger: Fix buffer overflow in Icmp6::Recv
---

diff --git a/src/icmp/Icmp6.cc b/src/icmp/Icmp6.cc
index 06bc9890cc..d84e632478 100644
--- a/src/icmp/Icmp6.cc
+++ b/src/icmp/Icmp6.cc
@@ -280,7 +280,7 @@ Icmp6::Recv(void)
 
 
         ip = (struct ip6_hdr *) pkt;
-        pkt += sizeof(ip6_hdr);
+        NP: echo size needs to +sizeof(ip6_hdr);
 
     debugs(42,0, HERE << "ip6_nxt=" << ip->ip6_nxt <<
     		", ip6_plen=" << ip->ip6_plen <<
@@ -291,7 +291,6 @@ Icmp6::Recv(void)
     */
 
     icmp6header = (struct icmp6_hdr *) pkt;
-    pkt += sizeof(icmp6_hdr);
 
     if (icmp6header->icmp6_type != ICMP6_ECHO_REPLY) {
 
@@ -316,7 +315,7 @@ Icmp6::Recv(void)
         return;
     }
 
-    echo = (icmpEchoData *) pkt;
+    echo = (icmpEchoData *) (pkt + sizeof(icmp6_hdr));
 
     preply.opcode = echo->opcode;