From: Daniel Gruno Date: Fri, 28 Mar 2014 20:43:15 +0000 (+0000) Subject: Add a note on t->r checking, as per RĂ¼diger's email. X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=37677e6b318bddd3bce6a752eedea2d29e8429f8;p=thirdparty%2Fapache%2Fhttpd.git Add a note on t->r checking, as per RĂ¼diger's email. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1582881 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/modules/lua/lua_apr.c b/modules/lua/lua_apr.c index 21651ead4ff..94761ba4b22 100644 --- a/modules/lua/lua_apr.c +++ b/modules/lua/lua_apr.c @@ -41,6 +41,10 @@ static int lua_table_set(lua_State *L) const char *key = luaL_checkstring(L, 2); const char *val = luaL_checkstring(L, 3); /* Unless it's the 'notes' table, check for newline chars */ + /* t->r will be NULL in case of the connection notes, but since + we aren't going to check anything called 'notes', we can safely + disregard checking whether t->r is defined. + */ if (strcmp(t->n, "notes") && ap_strchr_c(val, '\n')) { char *badchar; char *replacement = apr_pstrdup(t->r->pool, val);