From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 10 Mar 2015 14:42:18 +0000 (+0100)
Subject: struct _virNetworkDriverState: Annotate items
X-Git-Tag: v1.2.14-rc1~169
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=376b97799e1cf5a9cb2d3dab1bf1b9bf40147ead;p=thirdparty%2Flibvirt.git

struct _virNetworkDriverState: Annotate items

In order to drop network driver lock, lets annotate which
structure items are immutable, which have self-locking
APIs and so on.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/network/bridge_driver_platform.h b/src/network/bridge_driver_platform.h
index b7492e638e..904e73186b 100644
--- a/src/network/bridge_driver_platform.h
+++ b/src/network/bridge_driver_platform.h
@@ -34,16 +34,23 @@
 struct _virNetworkDriverState {
     virMutex lock;
 
+    /* Immutable pointer, self-locking APIs */
     virNetworkObjListPtr networks;
 
+    /* Immutable pointers, Immutable objects */
     char *networkConfigDir;
     char *networkAutostartDir;
     char *stateDir;
     char *pidDir;
     char *dnsmasqStateDir;
     char *radvdStateDir;
+
+    /* Require lock to get a reference on the object,
+     * lockless access thereafter
+     */
     dnsmasqCapsPtr dnsmasqCaps;
 
+    /* Immutable pointer, self-locking APIs */
     virObjectEventStatePtr networkEventState;
 };