From: Daniel P. Berrange <berrange@redhat.com>
Date: Wed, 14 Nov 2012 15:39:48 +0000 (+0000)
Subject: Fix uninitialized variable in virLXCControllerSetupDevPTS
X-Git-Tag: CVE-2012-3411~130
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3782814d4ad787d815e56382b6f809fe9020f14b;p=thirdparty%2Flibvirt.git

Fix uninitialized variable in virLXCControllerSetupDevPTS

The lack of initialization of 'opts' caused a SEGV in the
cleanup: path if the root->src directory did not exist
---

diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index a41c9037c6..2f1e8a57da 100644
--- a/src/lxc/lxc_controller.c
+++ b/src/lxc/lxc_controller.c
@@ -1144,7 +1144,7 @@ virLXCControllerSetupDevPTS(virLXCControllerPtr ctrl)
 {
     virDomainFSDefPtr root = virDomainGetRootFilesystem(ctrl->def);
     char *mount_options = NULL;
-    char *opts;
+    char *opts = NULL;
     char *devpts = NULL;
     int ret = -1;