From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Thu, 23 Nov 2023 11:02:58 +0000 (+0100)
Subject: datamodel: sync the whole list logging groups
X-Git-Tag: v6.0.5~7^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=379e384058f80d59cae863171863631f2fa3c686;p=thirdparty%2Fknot-resolver.git

datamodel: sync the whole list logging groups

Now that manager is integrated into kresd,
I expect these will naturally keep it in sync.
---

diff --git a/lib/log.h b/lib/log.h
index cd760ec5a..a3887e577 100644
--- a/lib/log.h
+++ b/lib/log.h
@@ -31,8 +31,8 @@ void kr_log_target_set(kr_log_target_t target);
 
 /* Groups */
 
-/* Don't forget add *_TAG below, log_group_names[] item (log.c) and generate
- * new kres-gen.lua */
+/* Don't forget add *_TAG below, log_group_names[] item (log.c) and generate new kres-gen.lua
+ * and sync the _TAG list with list in ../manager/knot_resolver_manager/datamodel/logging_schema.py */
 enum kr_log_group {
 	LOG_GRP_UNKNOWN = -1,
 	LOG_GRP_SYSTEM = 1,  /* Must be first in enum. */
diff --git a/manager/knot_resolver_manager/datamodel/logging_schema.py b/manager/knot_resolver_manager/datamodel/logging_schema.py
index 6d39c5c8a..d2b7b7e7a 100644
--- a/manager/knot_resolver_manager/datamodel/logging_schema.py
+++ b/manager/knot_resolver_manager/datamodel/logging_schema.py
@@ -22,6 +22,7 @@ LogGroupsEnum: TypeAlias = Literal[
     "manager",
     "supervisord",
     "cache-gc",
+    ## Now the LOG_GRP_*_TAG defines, exactly from ../../../lib/log.h
     "system",
     "cache",
     "io",
@@ -34,8 +35,6 @@ LogGroupsEnum: TypeAlias = Literal[
     "gnutls",
     "tls_cl",
     "xdp",
-    "zimprt",
-    "zscann",
     "doh",
     "dnssec",
     "hint",
@@ -66,7 +65,11 @@ LogGroupsEnum: TypeAlias = Literal[
     "contrl",
     "module",
     "devel",
-    "reqdbg",
+    "renum",
+    "exterr",
+    "rules",
+    "prlayr",
+    # "reqdbg",... (non-displayed section of the enum)
 ]
 
 
diff --git a/manager/knot_resolver_manager/datamodel/templates/logging.lua.j2 b/manager/knot_resolver_manager/datamodel/templates/logging.lua.j2
index 2fb398e97..2d5937a83 100644
--- a/manager/knot_resolver_manager/datamodel/templates/logging.lua.j2
+++ b/manager/knot_resolver_manager/datamodel/templates/logging.lua.j2
@@ -12,7 +12,7 @@ log_target('{{ cfg.logging.target }}')
 -- logging.groups
 log_groups({
 {% for g in cfg.logging.groups %}
-{% if g != "manager" and g != "supervisord" %}
+{% if g != "manager" and g != "supervisord" and g != "cache-gc" %}
     '{{ g }}',
 {% endif %}
 {% endfor %}