From: Jeff Garzik <jeff@garzik.org>
Date: Wed, 21 Feb 2007 00:42:39 +0000 (+0100)
Subject: [ATM] firestream: handle thrown error
X-Git-Tag: v2.6.16.42-rc1~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=379efed186cb110913caa2014bf6cbc396e1fefb;p=thirdparty%2Fkernel%2Fstable.git

[ATM] firestream: handle thrown error

gcc emits the following warning:

drivers/atm/firestream.c: In function ‘fs_open’:
drivers/atm/firestream.c:870: warning: ‘tmc0’ may be used uninitialized in this function

This indicates a real bug.  We should check make_rate() return value for
potential errors.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---

diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c
index 7f7ec288824d0..01eebd1ab80d6 100644
--- a/drivers/atm/firestream.c
+++ b/drivers/atm/firestream.c
@@ -1001,6 +1001,10 @@ static int fs_open(struct atm_vcc *atm_vcc)
 					r = ROUND_UP;
 				}
 				error = make_rate (pcr, r, &tmc0, NULL);
+				if (error) {
+					kfree(tc);
+					return error;
+				}
 			}
 			fs_dprintk (FS_DEBUG_OPEN, "pcr = %d.\n", pcr);
 		}