From: Ondřej Kuzník <ondra@mistotebe.net>
Date: Thu, 18 May 2017 15:12:06 +0000 (+0100)
Subject: Fix error handling wrt. its callers
X-Git-Tag: OPENLDAP_REL_ENG_2_5_1ALPHA~18^2~171
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=37a474b5085900b2552d92be2b7e9474fb2bfc30;p=thirdparty%2Fopenldap.git

Fix error handling wrt. its callers
---

diff --git a/servers/lloadd/operation.c b/servers/lloadd/operation.c
index 3436392f8f..0882222aed 100644
--- a/servers/lloadd/operation.c
+++ b/servers/lloadd/operation.c
@@ -517,7 +517,7 @@ request_abandon( Connection *c, Operation *op )
 {
     Operation *request, needle = { .o_client = c };
     ber_tag_t tag;
-    int rc = -1;
+    int rc = LDAP_SUCCESS;
 
     tag = ber_get_int( op->o_ber, &needle.o_client_msgid );
     if ( tag != LDAP_REQ_ABANDON ) {
@@ -535,7 +535,6 @@ request_abandon( Connection *c, Operation *op )
     operation_abandon( request );
     CONNECTION_LOCK_DECREF(c);
 
-    rc = LDAP_SUCCESS;
 done:
     operation_destroy_from_client( op );
     return rc;