From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Wed, 10 Dec 2025 14:48:48 +0000 (+0100)
Subject: homectl: trivial simplification
X-Git-Tag: v260-rc1~391^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=37ad11945109402b93dbd7f66a32742d94348f06;p=thirdparty%2Fsystemd.git

homectl: trivial simplification
---

diff --git a/src/home/homectl.c b/src/home/homectl.c
index 6112a3a07c4..ceb7fae7ee0 100644
--- a/src/home/homectl.c
+++ b/src/home/homectl.c
@@ -4944,18 +4944,13 @@ static int parse_argv(int argc, char *argv[]) {
                         break;
 
                 case ARG_KEY_NAME:
-                        if (isempty(optarg)) {
-                                arg_key_name = mfree(arg_key_name);
-                                return 0;
-                        }
-
-                        if (!filename_is_valid(optarg))
-                                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Specified key name not valid: %s", optarg);
+                        if (!isempty(optarg) && !filename_is_valid(optarg))
+                                return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
+                                                       "Parameter for --key-name= not a valid filename: %s", optarg);
 
-                        r = free_and_strdup_warn(&arg_key_name, optarg);
+                        r = free_and_strdup_warn(&arg_key_name, empty_to_null(optarg));
                         if (r < 0)
                                 return r;
-
                         break;
 
                 case ARG_SEIZE: