From: Joe Orton <jorton@apache.org>
Date: Mon, 30 Mar 2020 14:11:44 +0000 (+0000)
Subject: * modules/ssl/ssl_engine_io.c: Update comment, no function change, [skip ci]
X-Git-Tag: 2.5.0-alpha2-ci-test-only~1545
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=37b7d95791a23243d6341878658d19fa244373bb;p=thirdparty%2Fapache%2Fhttpd.git

* modules/ssl/ssl_engine_io.c: Update comment, no function change, [skip ci]


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1875883 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/ssl/ssl_engine_io.c b/modules/ssl/ssl_engine_io.c
index db3b24e2a78..bbcb6a38f93 100644
--- a/modules/ssl/ssl_engine_io.c
+++ b/modules/ssl/ssl_engine_io.c
@@ -1678,7 +1678,14 @@ static apr_status_t ssl_io_filter_input(ap_filter_t *f,
  * and introducing unnecessary overhead.
  *
  * ### This buffering could be probably be done more comprehensively
- * ### in ssl_io_filter_output itself. */
+ * ### in ssl_io_filter_output itself. 
+ * 
+ * ### Another possible performance optimisation in particular for the
+ * ### [HEAP] [FILE] HTTP response case is using a brigade rather than
+ * ### a char array to buffer; using apr_brigade_write() to append
+ * ### will use already-allocated memory from the HEAP, reducing # of
+ * ### copies.
+ */
 
 #define COALESCE_BYTES (AP_IOBUFSIZE)