From: Janis Johnson Date: Thu, 17 Jan 2008 03:21:36 +0000 (+0000) Subject: re PR rtl-optimization/33796 (valgrind error with -O2 for linux kernel code) X-Git-Tag: releases/gcc-4.3.0~579 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=37b87a3a8a76b5a00a8cd24f62b03ef3ba2c274a;p=thirdparty%2Fgcc.git re PR rtl-optimization/33796 (valgrind error with -O2 for linux kernel code) PR rtl-optimization/33796 * sparseset.c (sparseset_alloc): Use xcalloc rather than xmalloc. Co-Authored-By: Peter Bergner From-SVN: r131589 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e22f508a1a3f..e1e6f10a274f 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2007-01-16 Janis Johnson + Peter Bergner + + PR rtl-optimization/33796 + * sparseset.c (sparseset_alloc): Use xcalloc rather than xmalloc. + 2008-01-16 John David Anglin PR libgfortran/34699 diff --git a/gcc/sparseset.c b/gcc/sparseset.c index f556c4dc05c6..c8a9a301b593 100644 --- a/gcc/sparseset.c +++ b/gcc/sparseset.c @@ -30,7 +30,12 @@ sparseset_alloc (SPARSESET_ELT_TYPE n_elms) unsigned int n_bytes = sizeof (struct sparseset_def) + ((n_elms - 1) * 2 * sizeof (SPARSESET_ELT_TYPE)); - sparseset set = (sparseset) xmalloc (n_bytes); + /* We use xcalloc rather than xmalloc to silence some valgrind uninitialized + read errors when accessing set->sparse[n] when "n" is not, and never has + been, in the set. These uninitialized reads are expected, by design and + harmless. If this turns into a performance problem due to some future + additional users of sparseset, we can revisit this decision. */ + sparseset set = (sparseset) xcalloc (1, n_bytes); set->dense = &(set->elms[0]); set->sparse = &(set->elms[n_elms]); set->size = n_elms;