From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 22 Dec 2012 13:58:20 +0000 (+0100)
Subject: Rmoved useless variable in auth_digest.cc.
X-Git-Tag: SQUID_3_4_0_1~426
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3812fb2c88c97eb9044ad99a0f173a66a65c6d5a;p=thirdparty%2Fsquid.git

Rmoved useless variable in auth_digest.cc.

  Detected by Coverity Scan, issue 740594.
---

diff --git a/src/auth/digest/auth_digest.cc b/src/auth/digest/auth_digest.cc
index 608fbcd5d5..fb5b05c623 100644
--- a/src/auth/digest/auth_digest.cc
+++ b/src/auth/digest/auth_digest.cc
@@ -129,7 +129,6 @@ static digest_nonce_h *
 authenticateDigestNonceNew(void)
 {
     digest_nonce_h *newnonce = static_cast < digest_nonce_h * >(digest_nonce_pool->alloc());
-    digest_nonce_h *temp;
 
     /* NONCE CREATION - NOTES AND REASONING. RBC 20010108
      * === EXCERPT FROM RFC 2617 ===
@@ -183,7 +182,7 @@ authenticateDigestNonceNew(void)
      * have a random factor
      */
 
-    while ((temp = authenticateDigestNonceFindNonce((char const *) (newnonce->key)))) {
+    while (authenticateDigestNonceFindNonce((char const *) (newnonce->key))) {
         /* create a new nonce */
         newnonce->noncedata.randomdata = squid_random();
         /* Bug 3526 high performance fix: add 1 second to creationtime to avoid duplication */