From: Michael Tokarev Date: Wed, 14 Feb 2024 12:26:29 +0000 (+0300) Subject: silence "Can not convert group sid" warnings in the log X-Git-Tag: tdb-1.4.13~243 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3831a7e2fd41c3cba6d9c13f91582e8d8a3115c2;p=thirdparty%2Fsamba.git silence "Can not convert group sid" warnings in the log /var/log/samba/log.winbind is full of messages like: [2024/02/09 06:25:04.788182, 1, pid=74620] source3/winbindd/winbindd_getgroups.c:259(winbindd_getgroups_recv) Could not convert sid S-0-0: NT_STATUS_NONE_MAPPED On a busy server these are logged several 1000s times per minute, making any other messages basically invisible. This is a work-around, a proper solution is to handle some special SIDs (like this one) separately. Once this is done, this change can be reverted. Signed-off-by: Michael Tokarev Reviewed-by: Andreas Schneider Reviewed-by: Pavel Filipenský --- diff --git a/source3/winbindd/winbindd_getgroups.c b/source3/winbindd/winbindd_getgroups.c index 5f901d62d53..6c71390ad9a 100644 --- a/source3/winbindd/winbindd_getgroups.c +++ b/source3/winbindd/winbindd_getgroups.c @@ -259,7 +259,7 @@ NTSTATUS winbindd_getgroups_recv(struct tevent_req *req, if (tevent_req_is_nterror(req, &status)) { struct dom_sid_buf buf; - D_WARNING("Could not convert sid %s: %s\n", + D_DEBUG("Could not convert sid %s: %s\n", dom_sid_str_buf(&state->sid, &buf), nt_errstr(status)); return status;