From: Phil Oester <kernel@linuxace.com>
Date: Tue, 20 Jun 2006 13:45:38 +0000 (+0000)
Subject: REDIRECT does not accept IP (Phil Oester <kernel@linuxace.com>)
X-Git-Tag: v1.3.6~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3836fcc4c26ba831c38df7aa056863e8f24614a0;p=thirdparty%2Fiptables.git

REDIRECT does not accept IP (Phil Oester <kernel@linuxace.com>)

As pointed out by Nicolas Mailhot in bugzilla #483, REDIRECT
does not accept an IP address and when supplied with one,
provides unexpected results.  Patch below fixes this.
---

diff --git a/extensions/libipt_REDIRECT.c b/extensions/libipt_REDIRECT.c
index e29bf2ff..13195b0c 100644
--- a/extensions/libipt_REDIRECT.c
+++ b/extensions/libipt_REDIRECT.c
@@ -44,6 +44,9 @@ parse_ports(const char *arg, struct ip_nat_multi_range *mr)
 
 	mr->range[0].flags |= IP_NAT_RANGE_PROTO_SPECIFIED;
 
+	if (strchr(arg, '.'))
+		exit_error(PARAMETER_PROBLEM, "IP address not permitted\n");
+
 	port = atoi(arg);
 	if (port == 0 || port > 65535)
 		exit_error(PARAMETER_PROBLEM, "Port `%s' not valid\n", arg);