From: Colin Vidal <colin@isc.org>
Date: Tue, 7 Oct 2025 09:42:04 +0000 (+0200)
Subject: remove dns_zone_dump
X-Git-Tag: v9.21.15~75^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=383f14a36f1f2804f6a56e871cc0378c263279cc;p=thirdparty%2Fbind9.git

remove dns_zone_dump

Zone API `dns_zone_dump` is dead code in 9.21 (and was also dead code at
least in 9.20), removing it.
---

diff --git a/lib/dns/include/dns/zone.h b/lib/dns/include/dns/zone.h
index d468256a23b..83651ab1d9a 100644
--- a/lib/dns/include/dns/zone.h
+++ b/lib/dns/include/dns/zone.h
@@ -613,34 +613,21 @@ dns_zone_flush(dns_zone_t *zone);
  *\li	'zone' to be a valid zone.
  */
 
-isc_result_t
-dns_zone_dump(dns_zone_t *zone);
-/*%<
- *	Write the zone to database.
- *
- * Require:
- *\li	'zone' to be a valid zone.
- */
-
 isc_result_t
 dns_zone_dumptostream(dns_zone_t *zone, FILE *fd, dns_masterformat_t format,
 		      const dns_master_style_t *style,
 		      const uint32_t		rawversion);
 /*%<
  *    Write the zone to stream 'fd' in the specified 'format'.
- *    If the 'format' is dns_masterformat_text (RFC1035), 'style' also
- *    specifies the file style (e.g., &dns_master_style_default).
- *
- *    dns_zone_dumptostream() is a backward-compatible form of
- *    dns_zone_dumptostream2(), which always uses the dns_masterformat_text
- *    format and the dns_master_style_default style.
  *
- *    dns_zone_dumptostream2() is a backward-compatible form of
- *    dns_zone_dumptostream3(), which always uses the current
- *    default raw file format version.
+ *    If 'format' is dns_masterformat_text (RFC1035), 'style'
+ *    specifies the file style (e.g., &dns_master_style_default),
+ *    and 'rawversion' is ignored.
  *
- *    Note that dns_zone_dumptostream3() is the most flexible form.  It
- *    can also provide the functionality of dns_zone_fulldumptostream().
+ *    If 'format' is dns_masterformat_raw, 'style' is ignored, and
+ *    'rawversion" specifies the format verson of the raw zone file:
+ *    version 0 raw files can be read by all BIND 9 releases;
+ *    version 1 was introduced in BIND 9.9.
  *
  * Require:
  *\li	'zone' to be a valid zone.
diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index f56b6b7e531..0e66e8af180 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -12165,22 +12165,6 @@ dns_zone_flush(dns_zone_t *zone) {
 	return result;
 }
 
-isc_result_t
-dns_zone_dump(dns_zone_t *zone) {
-	isc_result_t result = ISC_R_ALREADYRUNNING;
-	bool dumping;
-
-	REQUIRE(DNS_ZONE_VALID(zone));
-
-	LOCK_ZONE(zone);
-	dumping = was_dumping(zone);
-	UNLOCK_ZONE(zone);
-	if (!dumping) {
-		result = zone_dump(zone, false);
-	}
-	return result;
-}
-
 static void
 zone_needdump(dns_zone_t *zone, unsigned int delay) {
 	isc_time_t dumptime;