From: Mark Michelson <mmichelson@digium.com>
Date: Wed, 21 Nov 2007 18:19:22 +0000 (+0000)
Subject: There existed about a 1 in 4 billion chance that reading from /dev/urandom
X-Git-Tag: 1.6.0-beta1~3^2~723
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3851bc9789bcdaf4259b1159cb1067559f89c47f;p=thirdparty%2Fasterisk.git

There existed about a 1 in 4 billion chance that reading from /dev/urandom
would return LONG_MIN (1 in 9 quintillion if using 64-bit longs). Since there
is no positive equivalent of LONG_MIN, the result of labs() in this case is
unpredictable. This fixes that situation.

(closes issue #11336, reported and patched by sperreault)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89487 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/utils.c b/main/utils.c
index 8b3448f029..83ab65ac1e 100644
--- a/main/utils.c
+++ b/main/utils.c
@@ -1140,7 +1140,7 @@ long int ast_random(void)
 	if (dev_urandom_fd >= 0) {
 		int read_res = read(dev_urandom_fd, &res, sizeof(res));
 		if (read_res > 0)
-			return labs(res);
+			return res < 0 ? ~res : res;
 	}
 #endif
 #ifdef linux