From: Mike Brady <4265913+mikebrady@users.noreply.github.com>
Date: Mon, 21 Mar 2022 22:12:35 +0000 (+1100)
Subject: Remember to close() the coverart directory file when finished iterating through it... 
X-Git-Tag: 4.1-rc1~24^2~239
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3877acc79aee4b49845fc410e53408b1a9976009;p=thirdparty%2Fshairport-sync.git

Remember to close() the coverart directory file when finished iterating through it to delete prior coverart files.
---

diff --git a/metadata_hub.c b/metadata_hub.c
index a899574a..4d21de52 100644
--- a/metadata_hub.c
+++ b/metadata_hub.c
@@ -298,8 +298,11 @@ char *metadata_write_image_file(const char *buf, int len) {
                   }
                 }
               }
+              if (close(dir_fd) < 0)
+                debug(1, "Error %d closing directory \"%s\"", errno, config.cover_art_cache_dir);
             } else {
-              debug(1, "Can't open the directory for deletion.");
+              debug(1, "Can't open the directory \"%s\" for deletion -- error %d.",
+                    config.cover_art_cache_dir, errno);
             }
             free(full_filename);
             closedir(d);