From: Jeremy Allison Date: Tue, 29 Sep 2020 03:04:51 +0000 (-0700) Subject: s3: smbd: SMB1 reply_mv() - the UCF_COND_ALLOW_WCARD_LCOMP makes no sense. X-Git-Tag: talloc-2.3.2~420 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=38bdb082b897e1b8e0fb3e36e815b6c447e42b84;p=thirdparty%2Fsamba.git s3: smbd: SMB1 reply_mv() - the UCF_COND_ALLOW_WCARD_LCOMP makes no sense. There's either a wildcard in the last component or not. Always use UCF_ALWAYS_ALLOW_WCARD_LCOMP for calls that can take a wildcard. Signed-off-by: Jeremy Allison Reviewed-by: Ralph Boehme --- diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c index b651bf4a3d6..fcac68147b1 100644 --- a/source3/smbd/reply.c +++ b/source3/smbd/reply.c @@ -8357,11 +8357,11 @@ void reply_mv(struct smb_request *req) uint32_t src_ucf_flags = ucf_flags_from_smb_request(req) | (req->posix_pathnames ? UCF_UNIX_NAME_LOOKUP : - UCF_COND_ALLOW_WCARD_LCOMP); + UCF_ALWAYS_ALLOW_WCARD_LCOMP); uint32_t dst_ucf_flags = ucf_flags_from_smb_request(req) | (req->posix_pathnames ? 0 : - UCF_COND_ALLOW_WCARD_LCOMP); + UCF_ALWAYS_ALLOW_WCARD_LCOMP); bool stream_rename = false; START_PROFILE(SMBmv);