From: Daniel P. Berrangé <berrange@redhat.com>
Date: Thu, 4 Jul 2019 10:24:37 +0000 (+0100)
Subject: remote: conditionally declare tty variable for non-Win32 platforms
X-Git-Tag: v5.6.0-rc1~317
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=38e93721256fb1cf3e6dcb4bb43282bcd9ff5aed;p=thirdparty%2Flibvirt.git

remote: conditionally declare tty variable for non-Win32 platforms

The 'tty' variable is only used on Win32. Instead of just annotating it
with ATTRIBUTE_UNUSED, make its declaration conditional on WIN32 so that
it is clear why it is not used.

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index c66775021e..925ada1cac 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -803,7 +803,9 @@ doRemoteOpen(virConnectPtr conn,
     VIR_AUTOFREE(char *) knownHosts = NULL;
     bool sanity = true;
     bool verify = true;
-    bool tty ATTRIBUTE_UNUSED = true;
+#ifndef WIN32
+    bool tty = true;
+#endif
 
     /* We handle *ALL* URIs here. The caller has rejected any
      * URIs we don't care about */
@@ -908,7 +910,9 @@ doRemoteOpen(virConnectPtr conn,
 
             EXTRACT_URI_ARG_BOOL("no_sanity", sanity);
             EXTRACT_URI_ARG_BOOL("no_verify", verify);
+#ifndef WIN32
             EXTRACT_URI_ARG_BOOL("no_tty", tty);
+#endif
 
             if (STRCASEEQ(var->name, "authfile")) {
                 /* Strip this param, used by virauth.c */