From: Fred Morcos <fred.morcos@open-xchange.com>
Date: Tue, 22 Nov 2022 09:55:14 +0000 (+0100)
Subject: Print checkKey() error messages in signer tests
X-Git-Tag: dnsdist-1.8.0-rc1~124^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3916c60f7d1505178515616989f3111699f94d42;p=thirdparty%2Fpdns.git

Print checkKey() error messages in signer tests
---

diff --git a/pdns/test-signers.cc b/pdns/test-signers.cc
index 6e27096bb8..523eb3a971 100644
--- a/pdns/test-signers.cc
+++ b/pdns/test-signers.cc
@@ -359,7 +359,15 @@ static void test_generic_signer(std::shared_ptr<DNSCryptoKeyEngine> dcke, DNSKEY
 {
   BOOST_CHECK_EQUAL(dcke->getAlgorithm(), signer.algorithm);
   BOOST_CHECK_EQUAL(dcke->getBits(), signer.bits);
-  BOOST_CHECK_EQUAL(dcke->checkKey(nullptr), true);
+
+  vector<string> errorMessages{};
+  BOOST_CHECK_EQUAL(dcke->checkKey(&errorMessages), true);
+  if (!errorMessages.empty()) {
+    BOOST_TEST_MESSAGE("Errors from " + dcke->getName() + " checkKey()");
+    for (auto& errorMessage : errorMessages) {
+      BOOST_TEST_MESSAGE("  " + errorMessage);
+    }
+  }
 
   BOOST_CHECK_EQUAL(drc.d_algorithm, signer.algorithm);