From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Wed, 2 Feb 2022 13:09:05 +0000 (+0100)
Subject: MINOR: quic: Variable used before being checked in ha_quic_add_handshake_data()
X-Git-Tag: v2.6-dev2~168
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3916ca197e8e21ab253204af70687b172685d92e;p=thirdparty%2Fhaproxy.git

MINOR: quic: Variable used before being checked in ha_quic_add_handshake_data()

This should fix Coverity CID 375058 in GH issue #1536
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index ddbe031476..29cffdeb13 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -1078,13 +1078,12 @@ int ha_quic_add_handshake_data(SSL *ssl, enum ssl_encryption_level_t level,
 	}
 
 	tel = ssl_to_quic_enc_level(level);
-	qel = &qc->els[tel];
-
 	if (tel == -1) {
 		TRACE_PROTO("Wrong encryption level", QUIC_EV_CONN_ADDDATA, qc);
 		goto err;
 	}
 
+	qel = &qc->els[tel];
 	if (!quic_crypto_data_cpy(qel, data, len)) {
 		TRACE_PROTO("Could not bufferize", QUIC_EV_CONN_ADDDATA, qc);
 		goto err;