From: Florian Apolloner <florian@apolloner.eu>
Date: Tue, 30 Mar 2021 11:28:35 +0000 (+0200)
Subject: BUG/MINOR: stats: Apply proper styles in HTML status page.
X-Git-Tag: v2.4-dev15~68
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=39272c28bffcf57c050703b356c9381df454dea7;p=thirdparty%2Fhaproxy.git

BUG/MINOR: stats: Apply proper styles in HTML status page.

When a backend is in status DOWN and going UP it is currently displayed
as yellow ("active UP, going down") instead of orange ("active DOWN, going
UP"). This patches restyles the table rows to actually match the
legend.

This may be backported to any version, the issue appeared in 1.7-dev2
with commit 0c378efe8 ("MEDIUM: stats: compute the color code only in
the HTML form").
---

diff --git a/src/stats.c b/src/stats.c
index e54d13adff..bfd05bbe2b 100644
--- a/src/stats.c
+++ b/src/stats.c
@@ -1079,13 +1079,13 @@ static int stats_dump_fields_html(struct buffer *out,
 		    strcmp(field_str(stats, ST_F_STATUS), "DOWN (agent)") == 0) {
 			style = "down";
 		}
-		else if (strcmp(field_str(stats, ST_F_STATUS), "DOWN ") == 0) {
+		else if (strncmp(field_str(stats, ST_F_STATUS), "DOWN ", strlen("DOWN ")) == 0) {
 			style = "going_up";
 		}
 		else if (strcmp(field_str(stats, ST_F_STATUS), "DRAIN") == 0) {
 			style = "draining";
 		}
-		else if (strcmp(field_str(stats, ST_F_STATUS), "NOLB ") == 0) {
+		else if (strncmp(field_str(stats, ST_F_STATUS), "NOLB ", strlen("NOLB ")) == 0) {
 			style = "going_down";
 		}
 		else if (strcmp(field_str(stats, ST_F_STATUS), "NOLB") == 0) {