From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 21 Aug 2023 01:49:38 +0000 (+1200)
Subject: s4:kdc: Check result of dom_sid_parse()
X-Git-Tag: tevent-0.16.0~630
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=39340f6518933e6de70ac19d97d0124009ed75af;p=thirdparty%2Fsamba.git

s4:kdc: Check result of dom_sid_parse()

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index 1f4e4ecf665..1a551191e59 100644
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -840,7 +840,9 @@ static NTSTATUS samba_add_asserted_identity(enum samba_asserted_identity ai,
 		return NT_STATUS_OK;
 	}
 
-	dom_sid_parse(sid_str, &ai_sid);
+	if (!dom_sid_parse(sid_str, &ai_sid)) {
+		return NT_STATUS_UNSUCCESSFUL;
+	}
 
 	return add_sid_to_array_attrs_unique(
 		user_info_dc,