From: Oliver Chen <oliver.chen@nokia-sbell.com>
Date: Mon, 14 Apr 2025 12:03:28 +0000 (+0000)
Subject: Fix clang-tidy warning of unnecessary std::move() for const ref
X-Git-Tag: dnsdist-2.0.0-alpha2~75^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=39477f9863ad758530c4ce5d17ed11b0e8611987;p=thirdparty%2Fpdns.git

Fix clang-tidy warning of unnecessary std::move() for const ref
---

diff --git a/pdns/dnsdistdist/dnsdist-backend.cc b/pdns/dnsdistdist/dnsdist-backend.cc
index 2465a2b726..31e9d254cd 100644
--- a/pdns/dnsdistdist/dnsdist-backend.cc
+++ b/pdns/dnsdistdist/dnsdist-backend.cc
@@ -452,7 +452,7 @@ void DownstreamState::handleUDPTimeout(IDState& ids)
   const auto& chains = dnsdist::configuration::getCurrentRuntimeConfiguration().d_ruleChains;
   const auto& timeoutRespRules = dnsdist::rules::getResponseRuleChain(chains, dnsdist::rules::ResponseRuleChain::TimeoutResponseRules);
   auto sender = ids.internal.du == nullptr ? nullptr : ids.internal.du->getQuerySender();
-  if (!handleTimeoutResponseRules(timeoutRespRules, ids.internal, shared_from_this(), std::move(sender))) {
+  if (!handleTimeoutResponseRules(timeoutRespRules, ids.internal, shared_from_this(), sender)) {
     DOHUnitInterface::handleTimeout(std::move(ids.internal.du));
   }