From: James Jones <jejones3141@gmail.com>
Date: Tue, 30 Aug 2022 14:08:08 +0000 (-0500)
Subject: Initialize rather than memcpy() (CID #1508486) (#4707)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=394ecfd1b8cfc384a88be5262065c186945dadb7;p=thirdparty%2Ffreeradius-server.git

Initialize rather than memcpy() (CID #1508486) (#4707)
---

diff --git a/src/lib/server/tmpl_eval.c b/src/lib/server/tmpl_eval.c
index 20fce154b92..2edb65cd25a 100644
--- a/src/lib/server/tmpl_eval.c
+++ b/src/lib/server/tmpl_eval.c
@@ -668,7 +668,7 @@ ssize_t _tmpl_to_atype(TALLOC_CTX *ctx, void *out,
 	fr_value_box_t		from_cast;
 
 	fr_pair_t		*vp = NULL;
-	fr_value_box_t		value;
+	fr_value_box_t		value = (fr_value_box_t){};
 	bool			needs_dup = false;
 
 	ssize_t			slen = -1;
@@ -678,8 +678,6 @@ ssize_t _tmpl_to_atype(TALLOC_CTX *ctx, void *out,
 
 	TMPL_VERIFY(vpt);
 
-	memset(&value, 0, sizeof(value));
-
 	switch (vpt->type) {
 	case TMPL_TYPE_UNRESOLVED:
 		RDEBUG4("EXPAND TMPL UNRESOLVED");