From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 27 Nov 2017 19:13:28 +0000 (-0500)
Subject: update notes
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=39712cccb41efe7c5c345c5da5db955dd2ce2182;p=thirdparty%2Ffreeradius-server.git

update notes
---

diff --git a/src/modules/proto_radius/proto_radius_udp.c b/src/modules/proto_radius/proto_radius_udp.c
index ded659959ad..0aa5aad0d52 100644
--- a/src/modules/proto_radius/proto_radius_udp.c
+++ b/src/modules/proto_radius/proto_radius_udp.c
@@ -497,8 +497,11 @@ static ssize_t dynamic_client_alloc(proto_radius_udp_t *inst, uint8_t *packet, s
 	/*
 	 *	It's now one of our clients (pending).
 	 *
-	 *	@todo - add creation time, and delete it when the
-	 *	request hits max_request_time.
+	 *	We can rely on the worker enforcing max_request_time,
+	 *	so we don't need to do something similar here.
+	 *
+	 *	i.e. if the client takes 30s to define, well, too
+	 *	bad...
 	 */
 	if (!client_add(inst->dynamic_clients.clients, client)) {
 		talloc_free(client);