From: Alejandro Colomar <alx@kernel.org>
Date: Thu, 9 Jan 2025 12:32:20 +0000 (+0100)
Subject: src/bin/duffman: Handle errors correctly
X-Git-Tag: man-pages-6.10~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3977fb05c8075fa3701e40fc9bd465d3aafb116e;p=thirdparty%2Fman-pages.git

src/bin/duffman: Handle errors correctly

In src/bin/duffman line 30:
cd $(git rev-parse --show-toplevel);
   ^-- SC2046 (warning): Quote this to prevent word splitting.
     ^---------------------------^ SC2312 (info): Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore).

Reported-by: shellcheck(1)
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/src/bin/duffman b/src/bin/duffman
index 273758d14..37fe8e820 100755
--- a/src/bin/duffman
+++ b/src/bin/duffman
@@ -27,7 +27,8 @@ if test $# -gt 2; then
 	exit 1;
 fi;
 
-cd $(git rev-parse --show-toplevel);
+git rev-parse --show-toplevel | read -r dir;
+cd "$dir";
 
 test -v MAN_KEEP_FORMATTING || export MAN_KEEP_FORMATTING=1;