From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Wed, 3 Jan 2024 14:04:11 +0000 (+0100)
Subject: Don't specify smm at all if it's not supported
X-Git-Tag: v20~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=398eb8816d33d6a6d8bb5a8678ce08576adbb873;p=thirdparty%2Fmkosi.git

Don't specify smm at all if it's not supported
---

diff --git a/mkosi/qemu.py b/mkosi/qemu.py
index 328bc4bc1..18131f6e2 100644
--- a/mkosi/qemu.py
+++ b/mkosi/qemu.py
@@ -541,8 +541,8 @@ def run_qemu(args: MkosiArgs, config: MkosiConfig, qemu_device_fds: Mapping[Qemu
         shm = ["-object", f"memory-backend-memfd,id=mem,size={config.qemu_mem},share=on"]
 
     machine = f"type={config.architecture.default_qemu_machine()}"
-    if firmware == QemuFirmware.uefi:
-        machine += f",smm={'on' if ovmf_supports_sb and config.architecture.supports_smm() else 'off'}"
+    if firmware == QemuFirmware.uefi and config.architecture.supports_smm():
+        machine += f",smm={'on' if ovmf_supports_sb else 'off'}"
     if shm:
         machine += ",memory-backend=mem"