From: Benjamin Drung <benjamin.drung@canonical.com>
Date: Sat, 15 Jun 2024 13:29:05 +0000 (+0200)
Subject: fix(zipl): quote zipl_env variable
X-Git-Tag: 103~111
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=39b1ffa2ea05cb20371bb9fc3b1bd2d386d419d3;p=thirdparty%2Fdracut-ng.git

fix(zipl): quote zipl_env variable

shellcheck complains about SC2086 (info): Double quote to prevent
globbing and word splitting.

Only strings without spaces are assigned to the `zipl_env` variable.
Therefore it is safe to be quoted.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
---

diff --git a/modules.d/91zipl/parse-zipl.sh b/modules.d/91zipl/parse-zipl.sh
index d95a1ddc4..dc0a2917d 100755
--- a/modules.d/91zipl/parse-zipl.sh
+++ b/modules.d/91zipl/parse-zipl.sh
@@ -42,7 +42,7 @@ if [ -n "$zipl_arg" ]; then
     if [ "$zipl_env" ]; then
         {
             printf 'ACTION=="add|change", SUBSYSTEM=="block", %s=="%s", ENV{SYSTEMD_READY}!="0", RUN+="/sbin/initqueue --settled --onetime --unique --name install_zipl_cmdline /sbin/install_zipl_cmdline.sh %s"\n' \
-                ${zipl_env} "${zipl_val}" "${zipl_arg}"
+                "${zipl_env}" "${zipl_val}" "${zipl_arg}"
             echo "[ -f /tmp/install.zipl.cmdline-done ]" > "$hookdir"/initqueue/finished/wait-zipl-conf.sh
         } >> /etc/udev/rules.d/99zipl-conf.rules
         cat /etc/udev/rules.d/99zipl-conf.rules