From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 11 Jun 2024 14:39:41 +0000 (+0200)
Subject: qemu_validate: Validate support for SCSI emulation support in 'virtio-blk' devices
X-Git-Tag: v10.5.0-rc1~92
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=39bfd6c8882d431d651acc36d22cdb7a1fad3845;p=thirdparty%2Flibvirt.git

qemu_validate: Validate support for SCSI emulation support in 'virtio-blk' devices

The support will be dropped soon by qemu, and libvirt is not rejecting
such configurations. Add validation of this explicitly requested config.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 3c04f47a12..b82d937a0d 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -2912,6 +2912,11 @@ qemuValidateDomainDeviceDefDiskFrontend(const virDomainDiskDef *disk,
             break;
 
         case VIR_DOMAIN_DISK_BUS_VIRTIO:
+            if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_BLK_SCSI)) {
+                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                               _("This QEMU doesn't support SCSI emulation with 'virtio-blk' device"));
+                return -1;
+            }
             break;
 
         case VIR_DOMAIN_DISK_BUS_NONE: