From: Joseph Sutton Date: Thu, 15 Dec 2022 23:47:02 +0000 (+1300) Subject: s4:torture: Remove assertion that primary group is not duplicated in user_info_dc X-Git-Tag: talloc-2.4.1~1653 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=39e2413585fdb76c11cb6b321cd247eb89f05659;p=thirdparty%2Fsamba.git s4:torture: Remove assertion that primary group is not duplicated in user_info_dc This assertion is one we will be breaking shortly. Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- diff --git a/source4/torture/rpc/remote_pac.c b/source4/torture/rpc/remote_pac.c index 28b9f1be523..214ecd0ff6c 100644 --- a/source4/torture/rpc/remote_pac.c +++ b/source4/torture/rpc/remote_pac.c @@ -979,13 +979,6 @@ static bool test_S4U2Self(struct torture_context *tctx, status = check_primary_group_in_validation(tmp_ctx, r.in.validation_level, r.out.validation); torture_assert_ntstatus_ok(tctx, status, "check_primary_group_in_validation failed"); - /* Check that the primary group is not duplicated in user_info_dc SID array */ - for (i = 2; i < netlogon_user_info_dc->num_sids; i++) { - torture_assert(tctx, !dom_sid_equal(&netlogon_user_info_dc->sids[1].sid, - &netlogon_user_info_dc->sids[i].sid), - "Duplicate PrimaryGroupId in return SID array"); - } - torture_assert_str_equal(tctx, netlogon_user_info_dc->info->account_name == NULL ? "" : netlogon_user_info_dc->info->account_name, kinit_session_info->info->account_name, "Account name differs for kinit-based PAC"); torture_assert_str_equal(tctx,netlogon_user_info_dc->info->account_name == NULL ? "" : netlogon_user_info_dc->info->account_name,