From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 22 Feb 2024 12:29:07 +0000 (+0100)
Subject: docs: newapi: Don't generate empty <div> in template for ACL permissions
X-Git-Tag: v10.2.0-rc1~143
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3a0af92df6f43b1dac9aa80164d87e41db4c6b95;p=thirdparty%2Flibvirt.git

docs: newapi: Don't generate empty <div> in template for ACL permissions

If an API has no ACLs an empty <div class='acl'/> would be generated
which is mis-interpreted by browsers when creating DOM to nest any
subsequent elements under it.

Don't generate the ACL section div unless it will be filled.

Best viewed with 'git show -w'

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
---

diff --git a/docs/newapi.xsl b/docs/newapi.xsl
index 38cefb2ca8..b60680ae97 100644
--- a/docs/newapi.xsl
+++ b/docs/newapi.xsl
@@ -26,30 +26,34 @@
   <xsl:template name="aclinfo">
     <xsl:param name="acl"/>
 
-    <xsl:if test="count($acl/check) > 0">
-      <h5>Access control parameter checks</h5>
-      <table>
-        <thead>
-          <tr>
-            <th>Object</th>
-            <th>Permission</th>
-            <th>Condition</th>
-          </tr>
-        </thead>
-        <xsl:apply-templates select="$acl/check" mode="acl"/>
-      </table>
-    </xsl:if>
-    <xsl:if test="count($acl/filter) > 0">
-      <h5>Access control return value filters</h5>
-      <table>
-        <thead>
-          <tr>
-            <th>Object</th>
-            <th>Permission</th>
-          </tr>
-        </thead>
-        <xsl:apply-templates select="$acl/filter" mode="acl"/>
-      </table>
+    <xsl:if test="count($acl/check) > 0 or count($acl/filter) > 0">
+      <div class="acl">
+        <xsl:if test="count($acl/check) > 0">
+          <h5>Access control parameter checks</h5>
+          <table>
+            <thead>
+              <tr>
+                <th>Object</th>
+                <th>Permission</th>
+                <th>Condition</th>
+              </tr>
+            </thead>
+            <xsl:apply-templates select="$acl/check" mode="acl"/>
+          </table>
+        </xsl:if>
+        <xsl:if test="count($acl/filter) > 0">
+          <h5>Access control return value filters</h5>
+          <table>
+            <thead>
+              <tr>
+                <th>Object</th>
+                <th>Permission</th>
+              </tr>
+            </thead>
+            <xsl:apply-templates select="$acl/filter" mode="acl"/>
+          </table>
+        </xsl:if>
+      </div>
     </xsl:if>
   </xsl:template>
 
@@ -702,11 +706,9 @@
         </xsl:if>
       </dl>
     </xsl:if>
-    <div class="acl">
-      <xsl:call-template name="aclinfo">
-        <xsl:with-param name="acl" select="acls"/>
-      </xsl:call-template>
-    </div>
+    <xsl:call-template name="aclinfo">
+      <xsl:with-param name="acl" select="acls"/>
+    </xsl:call-template>
   </xsl:template>
 
   <xsl:template match="exports" mode="toc">